netdev - Re: [PATCH net-next 02/11] ip6mr: Make mroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7408877-c90f-c85e-f00a-34c80ec95e36@cumulusnetworks.com>
Date:   Tue, 27 Feb 2018 22:10:49 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Yuval Mintz <yuvalm@...lanox.com>, netdev@...r.kernel.org
Cc:     mlxsw@...lanox.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next 02/11] ip6mr: Make mroute_sk rcu-based

On 27/02/18 20:58, Yuval Mintz wrote:
> In ipmr the mr_table socket is handled under RCU. Introduce the same
> for ip6mr.
> 
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> ---
>  include/linux/mroute6.h |  6 +++---
>  net/ipv6/ip6_output.c   |  2 +-
>  net/ipv6/ip6mr.c        | 45 +++++++++++++++++++++++++++------------------
>  3 files changed, 31 insertions(+), 22 deletions(-)

LGTM, though do we need the write_lock when changing mroute6_sk after RCUfying it ?
In any case that can be resolved later,

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>