netdev - Re: [patch net-next 15/15] mlxsw: spectrum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wihinahmbb2.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Wed, 28 Feb 2018 16:35:45 +0200
From:   Petr Machata <petrm@...lanox.com>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        idosch@...lanox.com, davem@...emloft.net, mlxsw@...lanox.com,
        xeb@...l.ru
Subject: Re: [patch net-next 15/15] mlxsw: spectrum_span: Support mirror to ip6gretap

David Ahern <dsa@...ulusnetworks.com> writes:

> On 2/27/18 6:53 AM, Jiri Pirko wrote:
>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>> index 830c3e28505e..93d97b4676eb 100644
>> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>> +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>> @@ -80,6 +80,8 @@ config MLXSW_SPECTRUM
>>  	select MLXFW
>>  	depends on NET_IPGRE
>>  	depends on !(MLXSW_CORE=y && NET_IPGRE=m)
>> +	depends on IPV6_GRE
>> +	depends on !(MLXSW_CORE=y && IPV6_GRE=m)
>>  	default m
>>  	---help---
>>  	  This driver supports Mellanox Technologies Spectrum Ethernet
>
> Since mlxsw now has a hard dependency on IPv6 the 'if
> IS_ENABLED(CONFIG_IPV6)' checks can be removed from the spectrum code.

I'll add a default implementation of is_gretap_dev and is_ip6gretap_dev
for cases where the corresponding code is not selected so that the
Spectrum driver doesn't depend on all these modules.

Thanks,
Petr