netdev - RE: [PATCH net-next] team: Use extack to report enslavement failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0501MB2784F60B815D34409EC0B72CBFC70@VI1PR0501MB2784.eurprd05.prod.outlook.com>
Date:   Wed, 28 Feb 2018 07:21:26 +0000
From:   Yuval Mintz <yuvalm@...lanox.com>
To:     Jiri Pirko <jiri@...nulli.us>, Jakub Kicinski <kubakici@...pl>
CC:     Ido Schimmel <idosch@...sch.org>, Jiri Benc <jbenc@...hat.com>,
        "Ido Schimmel" <idosch@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Jiri Pirko" <jiri@...lanox.com>,
        "dsahern@...il.com" <dsahern@...il.com>, mlxsw <mlxsw@...lanox.com>
Subject: RE: [PATCH net-next] team: Use extack to report enslavement failures

> >> > If so, for how long? They should certainly be removed eventually. How
> >> > do we ensure we don't forget?
> >> >
> >> > Seems to me it would be better to remove them right now.
> >>
> >> I can do that unless someone objects.
> >
> >I don't object, but FWIW keep in mind extack errors don't show if
> >libmnl is not installed..
> 
> Yeah, or if you have an older iproute2 package. I would keep the existing
> dmesg msgs for now. In the future, when everyone is used to exacks, then
> we can remove them.

Perhaps it makes sense to introduce netdev_nl_err_msg(dev, extack, msg)
that would do both today and refactor the code to use it?
Later it could be changed to do only NL_SET_ERR_MSG.