netdev - Re: [PATCH] net: allow interface to be set into vrf if a vif in same vrf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180301.132824.1050652529981791013.davem@davemloft.net>
Date:   Thu, 01 Mar 2018 13:28:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mmanning@...tta.mail-att.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH] net: allow interface to be set into vrf if a vif in
 same vrf

From: Mike Manning <mmanning@...tta.mail-att.com>
Date: Mon, 26 Feb 2018 16:48:56 +0000

> Setting an interface into a vrf fails with 'RTNETLINK answers: File
> exists' if one of its vifs is already in the same vrf. As the vrf is an
> upper device of the vif, it is also showing up as an upper device of
> the interface itself. The solution is to restrict this check to devices
> other than master. As only one master device can be linked to a device,
> in this case the check is for the upper device (vrf) to be linked to as
> being the master device rather than any other upper device.
> 
> Signed-off-by: Mike Manning <mmanning@....com>

David A., please review.