netdev - Re: [PATCH net-next 1/5] selftests: forwarding: Only check tc version for tc tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180301201209.GA8190@splinter>
Date:   Thu, 1 Mar 2018 22:12:09 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        idosch@...lanox.com, jiri@...lanox.com
Subject: Re: [PATCH net-next 1/5] selftests: forwarding: Only check tc
 version for tc tests

On Thu, Mar 01, 2018 at 11:09:43AM -0800, David Ahern wrote:
> Capabilities of tc command are irrelevant for router tests:
>     $ ./router.sh
>     SKIP: iproute2 too old, missing shared block support
> 
> Add a CHECK_TC flag and only check tc capabilities if set. Add flag to
> tc_common.sh and have it sourced before lib.sh
> 
> Also, if the command lacks some feature the test should exit non-0.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh      | 29 ++++++++++++++--------
>  .../testing/selftests/net/forwarding/tc_actions.sh |  2 +-
>  .../testing/selftests/net/forwarding/tc_chains.sh  |  2 +-
>  .../testing/selftests/net/forwarding/tc_common.sh  |  2 ++
>  .../testing/selftests/net/forwarding/tc_flower.sh  |  2 +-
>  .../selftests/net/forwarding/tc_shblocks.sh        |  2 +-

bridge_vlan_aware.sh also uses tc to check flooding and learning. Looks
good otherwise.

Reviewed-by: Ido Schimmel <idosch@...lanox.com>

Thanks, David!