netdev - Re: [RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180301201135.GA343@lunn.ch>
Date:   Thu, 1 Mar 2018 21:11:35 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com, f.fainelli@...il.com,
        davem@...emloft.net
Subject: Re: [RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for
 National Instruments XGE netdev

Hi Moritz

> - Consistency for NIXGE_MDIO_CXX_READ constants

> +#define NIXGE_MDIO_CLAUSE45	BIT(12)
> +#define NIXGE_MDIO_CLAUSE22	0
> +#define NIXGE_MDIO_OP(n)     (((n) & 0x3) << 10)
> +#define NIXGE_MDIO_OP_ADDRESS	0
> +#define NIXGE_MDIO_OP_WRITE	BIT(0)
> +#define NIXGE_MDIO_C45_READ	(BIT(1) | BIT(0))
> +#define NIXGE_MDIO_C22_WRITE	BIT(0)
> +#define NIXGE_MDIO_C22_READ	BIT(1)

Thanks for making READ consistent. But what about WRITE?  I'd suggest
you don't just blindly follow comments, but think about them.

    Andrew