netdev - Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180302.094221.175357357339220581.davem@davemloft.net>
Date:   Fri, 02 Mar 2018 09:42:21 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     santosh.shilimkar@...cle.com
Cc:     ka-cheong.poon@...cle.com, netdev@...r.kernel.org,
        rds-devel@....oracle.com, sowmini.varadhan@...cle.com
Subject: Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket
 creation

From: "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
Date: Thu, 1 Mar 2018 22:22:07 -0800

> Versioning comment typically goes below "---" and not part of
> commit message.

I like them to be in the commit message most of the time.

Especially for patch series header postings.

Later if someone reviews the patch and says "why didn't they do X" and
if it says in the version history text "don't do X based upon feedback
from developer Y" that helps a lot.