netdev - Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <781ca50f-9974-0649-6c0f-84080182ffdc@oracle.com>
Date:   Fri, 2 Mar 2018 10:08:13 -0800
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     ka-cheong.poon@...cle.com, netdev@...r.kernel.org,
        rds-devel@....oracle.com, sowmini.varadhan@...cle.com
Subject: Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket
 creation

On 3/2/2018 6:42 AM, David Miller wrote:
> From: "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
> Date: Thu, 1 Mar 2018 22:22:07 -0800
> 
>> Versioning comment typically goes below "---" and not part of
>> commit message.
> 
> I like them to be in the commit message most of the time.
> 
> Especially for patch series header postings.
>
Series header I have seen it followed but not in patch commit since
it goes into kernel git history.

> Later if someone reviews the patch and says "why didn't they do X" and
> if it says in the version history text "don't do X based upon feedback
> from developer Y" that helps a lot.
> 
I agree the versioning info helps, but didn't know that you like that
to be in commit message of patches as well. Will keep that in mind for
future for netdev list.

Regards,
Santosh