netdev - Re: [PATCH v3 net-next 06/10] net/ipv6: Pass skb to route lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54a6e10e-5fcf-7d45-38be-ed935fe56bd9@cumulusnetworks.com>
Date:   Fri, 2 Mar 2018 19:47:04 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Cc:     idosch@...sch.org, davem@...emloft.net, roopa@...ulusnetworks.com,
        tom@...bertland.com
Subject: Re: [PATCH v3 net-next 06/10] net/ipv6: Pass skb to route lookup

On 02/03/18 18:32, David Ahern wrote:
> IPv6 does path selection for multipath routes deep in the lookup
> functions. The next patch adds L4 hash option and needs the skb
> for the forward path. To get the skb to the relevant FIB lookup
> functions it needs to go through the fib rules layer, so add a
> lookup_data argument to the fib_lookup_arg struct.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  drivers/infiniband/core/cma.c      |  2 +-
>  drivers/net/ipvlan/ipvlan_core.c   |  3 +-
>  drivers/net/vrf.c                  |  7 ++--
>  include/net/fib_rules.h            |  1 +
>  include/net/ip6_fib.h              |  4 ++-
>  include/net/ip6_route.h            | 11 +++---
>  net/ipv6/anycast.c                 |  2 +-
>  net/ipv6/fib6_rules.c              |  8 +++--
>  net/ipv6/icmp.c                    |  3 +-
>  net/ipv6/ip6_fib.c                 |  3 +-
>  net/ipv6/ip6_gre.c                 |  2 +-
>  net/ipv6/ip6_tunnel.c              |  4 +--
>  net/ipv6/ip6_vti.c                 |  2 +-
>  net/ipv6/mcast.c                   |  4 +--
>  net/ipv6/netfilter/ip6t_rpfilter.c |  2 +-
>  net/ipv6/netfilter/nft_fib_ipv6.c  |  3 +-
>  net/ipv6/route.c                   | 72 +++++++++++++++++++++++---------------
>  net/ipv6/seg6_local.c              |  4 +--
>  18 files changed, 83 insertions(+), 54 deletions(-)
> 

Indeed, I remember this requirement back when I was making the IPv4
changes and looked into how IPv6 is handled, skb wasn't passed down
until now. Looks good to me!

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>