netdev - Re: [PATCH v3 net-next 07/10] net/ipv6: Add support for path selection using hash of 5-tuple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44621375-9967-0419-098e-761c66d62687@cumulusnetworks.com>
Date:   Fri, 2 Mar 2018 19:49:09 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Cc:     idosch@...sch.org, davem@...emloft.net, roopa@...ulusnetworks.com,
        tom@...bertland.com
Subject: Re: [PATCH v3 net-next 07/10] net/ipv6: Add support for path
 selection using hash of 5-tuple

On 02/03/18 18:32, David Ahern wrote:
> Some operators prefer IPv6 path selection to use a standard 5-tuple
> hash rather than just an L3 hash with the flow the label. To that end
> add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb
> ("net: ipv4: add support for ECMP hash policy choice"). The default
> is still L3 which covers source and destination addresses along with
> flow label and IPv6 protocol.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> Tested-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  Documentation/networking/ip-sysctl.txt |  7 ++++
>  include/net/ip6_route.h                |  4 +-
>  include/net/netevent.h                 |  1 +
>  include/net/netns/ipv6.h               |  1 +
>  net/ipv6/icmp.c                        |  2 +-
>  net/ipv6/route.c                       | 68 ++++++++++++++++++++++++++--------
>  net/ipv6/sysctl_net_ipv6.c             | 27 ++++++++++++++
>  7 files changed, 91 insertions(+), 19 deletions(-)
> 

LGTM,

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>