netdev - Re: [PATCH net-next] socket: skip checking sk_err for recvmmsg(MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180301.212844.469268023967788683.davem@davemloft.net>
Date:   Thu, 01 Mar 2018 21:28:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     soheil.kdev@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, willemb@...gle.com,
        soheil@...gle.com
Subject: Re: [PATCH net-next] socket: skip checking sk_err for
 recvmmsg(MSG_ERRQUEUE)

From: Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Date: Tue, 27 Feb 2018 18:22:40 -0500

> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> recvmmsg does not call ___sys_recvmsg when sk_err is set.
> That is fine for normal reads but, for MSG_ERRQUEUE, recvmmsg
> should always call ___sys_recvmsg regardless of sk->sk_err to
> be able to clear error queue. Otherwise, users are not able to
> drain the error queue using recvmmsg.
> 
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thank you.