netdev - Re: [PATCH net V2] virtio-net: re enable XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8898264-a2a3-9b0b-d66c-d7b1ad4e139e@redhat.com>
Date:   Mon, 5 Mar 2018 10:39:14 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        john.fastabend@...il.com
Subject: Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable
 buffer



On 2018年03月03日 00:07, Jesper Dangaard Brouer wrote:
> On Fri,  2 Mar 2018 17:29:14 +0800
> Jason Wang <jasowang@...hat.com> wrote:
>
>> XDP_REDIRECT support for mergeable buffer was removed since commit
>> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
>> case"). This is because we don't reserve enough tailroom for struct
>> skb_shared_info which breaks XDP assumption. So this patch fixes this
>> by reserving enough tailroom and using fixed size of rx buffer.
>>
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
>> ---
>> Changes from V1:
>> - do not add duplicated tracepoint when redirection fails
> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>
>
> I gave it a quick spin on my testlab, and cpumap seems to
> work/not-crash now (if I managed to turn back config to
> receive_mergeable() correctly ;-)).
>


Thanks for the testing and reviewing.