netdev - Re: [PATCH net V2] virtio-net: re enable XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abf2cb49-64bd-16ce-23e1-53aa719243d0@redhat.com>
Date:   Mon, 5 Mar 2018 10:41:29 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, brouer@...hat.com,
        john.fastabend@...il.com
Subject: Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable
 buffer



On 2018年03月03日 01:36, Michael S. Tsirkin wrote:
> On Fri, Mar 02, 2018 at 05:29:14PM +0800, Jason Wang wrote:
>> XDP_REDIRECT support for mergeable buffer was removed since commit
>> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
>> case"). This is because we don't reserve enough tailroom for struct
>> skb_shared_info which breaks XDP assumption. So this patch fixes this
>> by reserving enough tailroom and using fixed size of rx buffer.
>>
>> Signed-off-by: Jason Wang<jasowang@...hat.com>
> Acked-by: Michael S. Tsirkin<mst@...hat.com>
>
> I think the next incremental step is to look at splitting
> out fast path XDP processing to a separate set of functions.
>

Let me try (probably after 1.1 stuffs).

Thanks