netdev - Re: [PATCH net] net: usbnet: fix potential deadlock on 32bit hosts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180307.114707.969533359930427360.davem@davemloft.net>
Date:   Wed, 07 Mar 2018 11:47:07 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     oneukum@...e.com, m.szyprowski@...sung.com,
        linux-samsung-soc@...r.kernel.org, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, Dean_Jenkins@...tor.com
Subject: Re: [PATCH net] net: usbnet: fix potential deadlock on 32bit hosts

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 05 Mar 2018 11:41:13 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Marek reported a LOCKDEP issue occurring on 32bit host,
> that we tracked down to the fact that usbnet could either
> run from soft or hard irqs.
> 
> This patch adds u64_stats_update_begin_irqsave() and
> u64_stats_update_end_irqrestore() helpers to solve this case.
 ...
> Fixes: c8b5d129ee29 ("net: usbnet: support 64bit stats")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Cc: Greg Ungerer <gerg@...ux-m68k.org>

Applied and queued up for -stable, thanks Eric.