netdev - Re: [PATCH iproute2-next 2/3] ipmroute: don't complain about unicast routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d72d5f82-e4f9-f4bf-a596-529db69effc8@gmail.com>
Date:   Wed, 7 Mar 2018 09:47:37 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH iproute2-next 2/3] ipmroute: don't complain about unicast
 routes

On 3/7/18 9:03 AM, Stephen Hemminger wrote:
> On Tue,  6 Mar 2018 17:03:54 -0800
> Stephen Hemminger <stephen@...workplumber.org> wrote:
> 
>> From: Stephen Hemminger <sthemmin@...rosoft.com>
>>
>> Every non-multicast route prints an error message.
>> Kernel doesn't filter out unicast routes, it is up to filter function
>> to do this.
>>
>> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>> ---
>>  ip/ipmroute.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/ip/ipmroute.c b/ip/ipmroute.c
>> index aa5029b44f41..03ca0575e571 100644
>> --- a/ip/ipmroute.c
>> +++ b/ip/ipmroute.c
>> @@ -75,15 +75,14 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>>  		fprintf(stderr, "BUG: wrong nlmsg len %d\n", len);
>>  		return -1;
>>  	}
>> -	if (r->rtm_type != RTN_MULTICAST) {
>> -		fprintf(stderr, "Not a multicast route (type: %s)\n",
>> -			rtnl_rtntype_n2a(r->rtm_type, b1, sizeof(b1)));
>> +
>> +	if (r->rtm_type != RTN_MULTICAST)
>>  		return 0;
>> -	}
>>  
>>  	parse_rtattr(tb, RTA_MAX, RTM_RTA(r), len);
>>  	table = rtm_get_table(r, tb);
>>  
>> +
>>  	if (filter.tb > 0 && filter.tb != table)
>>  		return 0;
>>  
> 
> Actually, this is a recent kernel regression. Should be fixed there
> 

from Yuval's recent multicast convergence changes?