netdev - Re: [PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180308073837.7c21b7d2@xeon-e3>
Date:   Thu, 8 Mar 2018 07:38:37 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip-address: Fix negative prints of large
 TX rate limits

On Thu,  8 Mar 2018 15:48:27 +0200
Tariq Toukan <tariqt@...lanox.com> wrote:

>  	if (vf_tx_rate->rate)
>  		print_int(PRINT_ANY,
>  			  "tx_rate",
> -			  ", tx rate %d (Mbps)",
> +			  ", tx rate %u (Mbps)",
>  			  vf_tx_rate->rate)

JSON output has same sign bug. You need to use print_uint here.