netdev - Re: [PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94a4561b-34f3-47cd-75ec-5976c708b6fe@mellanox.com>
Date:   Thu, 8 Mar 2018 17:56:50 +0200
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Tariq Toukan <tariqt@...lanox.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip-address: Fix negative prints of large TX
 rate limits



On 08/03/2018 5:38 PM, Stephen Hemminger wrote:
> On Thu,  8 Mar 2018 15:48:27 +0200
> Tariq Toukan <tariqt@...lanox.com> wrote:
> 
>>   	if (vf_tx_rate->rate)
>>   		print_int(PRINT_ANY,
>>   			  "tx_rate",
>> -			  ", tx rate %d (Mbps)",
>> +			  ", tx rate %u (Mbps)",
>>   			  vf_tx_rate->rate)
> 
> JSON output has same sign bug. You need to use print_uint here.
> 
Thanks Stephen, I'm fixing it...