netdev - Re: [PATCH net-next] ipvlan: properly annotate rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180308.111256.1393059893437825412.davem@davemloft.net>
Date:   Thu, 08 Mar 2018 11:12:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, maheshb@...gle.com, jbenc@...hat.com
Subject: Re: [PATCH net-next] ipvlan: properly annotate rx_handler access

From: Paolo Abeni <pabeni@...hat.com>
Date: Thu,  8 Mar 2018 10:29:30 +0100

> The rx_handler field is rcu-protected, but I forgot to use the
> proper accessor while refactoring netif_is_ipvlan_port(). Such
> function only check the rx_handler value, so it is safe, but we need
> to properly read rx_handler via rcu_access_pointer() to avoid sparse
> warnings.
> 
> Fixes: 1ec54cb44e67 ("net: unpollute priv_flags space")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.