netdev - Re: [PATCH] pktgen: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180309.115810.954232560207995724.davem@davemloft.net>
Date:   Fri, 09 Mar 2018 11:58:10 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        garsilva@...eddedor.com
Subject: Re: [PATCH] pktgen: Remove VLA usage

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Thu, 8 Mar 2018 23:43:40 -0600

> In preparation to enabling -Wvla, remove VLA usage and replace it
> with a fixed-length array instead.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
> David,
> 
> I'm not sure how often this function is being called and,
> depending on the frequency it may be worth to use
> dynamic memory allocation instead?

It happens every time a config setting is made via the sysfs
files when debug is enabled.

This is not something that happens often.

So your patch is fine, applied to net-next, thanks.