netdev - Re: [PATCH] pktgen: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c118fc1c-99fc-db64-5065-e26f8d4432ed@embeddedor.com>
Date:   Fri, 9 Mar 2018 12:33:23 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     David Miller <davem@...emloft.net>, gustavo@...eddedor.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pktgen: Remove VLA usage

On 03/09/2018 10:58 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
> Date: Thu, 8 Mar 2018 23:43:40 -0600
> 
>> In preparation to enabling -Wvla, remove VLA usage and replace it
>> with a fixed-length array instead.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>> David,
>>
>> I'm not sure how often this function is being called and,
>> depending on the frequency it may be worth to use
>> dynamic memory allocation instead?
> 
> It happens every time a config setting is made via the sysfs
> files when debug is enabled.
> 
> This is not something that happens often.
> 

I got it.

> So your patch is fine, applied to net-next, thanks.
> 

Awesome.

Thanks, David.
--
Gustavo