netdev - Re: [PATCH bpf-next 0/7] tools: bpf: standardize make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180308233608.4e3ef4b5@cakuba.netronome.com>
Date:   Thu, 8 Mar 2018 23:36:08 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Jiri Benc <jbenc@...hat.com>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next 0/7] tools: bpf: standardize make

On Thu, 8 Mar 2018 21:10:59 -0800, Alexei Starovoitov wrote:
> On Thu, Mar 8, 2018 at 2:00 PM, Jiri Benc <jbenc@...hat.com> wrote:
> > Currently, 'make bpf' in the tools/ directory does not provide the standard
> > quiet output except for bpftool (which is however listed with a wrong
> > directory). Worse, it does not respect the build output directory.
> >
> > The 'make bpf_install' does not work as one would expect, either. It
> > installs unconditionally to /usr/bin without respecting DESTDIR and prefix.
> >
> > This patchset improves that behavior.  
> 
> Jakub,
> please review this set.
> 
> Thanks!

I stared at it for a while, and it looks good!

Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

In addition I found a GCC 7 warning in bpftool, .PHONY lacks some
targets and we don't clean up after feature detection.  I'll send
patches for that unless someone beats me to it.