netdev - Re: [PATCH 12/15] ice: Add stats and ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 09 Mar 2018 21:35:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     kubakici@...pl
Cc:     anirudh.venkataramanan@...el.com, intel-wired-lan@...ts.osuosl.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support

From: Jakub Kicinski <kubakici@...pl>
Date: Fri, 9 Mar 2018 15:14:28 -0800

> On Fri,  9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote:
>> +static const struct ice_stats ice_net_stats[] = {
>> +	ICE_NETDEV_STAT(rx_packets),
>> +	ICE_NETDEV_STAT(tx_packets),
>> +	ICE_NETDEV_STAT(rx_bytes),
>> +	ICE_NETDEV_STAT(tx_bytes),
>> +	ICE_NETDEV_STAT(rx_errors),
>> +	ICE_NETDEV_STAT(tx_errors),
>> +	ICE_NETDEV_STAT(rx_dropped),
>> +	ICE_NETDEV_STAT(tx_dropped),
>> +	ICE_NETDEV_STAT(multicast),
>> +	ICE_NETDEV_STAT(rx_length_errors),
>> +	ICE_NETDEV_STAT(rx_crc_errors),
>> +};
> 
> Please don't duplicate standard netdev stats in ethtool -S.

Indeed, unless you are providing per-queue versions of these
stats, don't do this.