netdev - Re: [PATCH 12/15] ice: Add stats and ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180310083752.320dab33@xeon-e3>
Date:   Sat, 10 Mar 2018 08:37:52 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support

On Fri,  9 Mar 2018 09:21:33 -0800
Anirudh Venkataramanan <anirudh.venkataramanan@...el.com> wrote:

> +	/* VSI stats */
> +	struct rtnl_link_stats64 net_stats;
> +	struct rtnl_link_stats64 net_stats_prev;
> +	struct ice_eth_stats eth_stats;
> +	struct ice_eth_stats eth_stats_prev;
> +

There is already a stats64 in netdev.
You might want to also consider per-cpu statistics since incrementing
a shared counter is cache unfriendly.