netdev - Re: [PATCH net-next 1/5] bridge: initialize port flags with switchdev defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180310083234.47db5f06@xeon-e3>
Date:   Sat, 10 Mar 2018 08:32:34 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Igor Mitsyanko <igor.mitsyanko.os@...ntenna.com>
Cc:     bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
        sergey.matyukevich.os@...ntenna.com, smaksimenko@...ntenna.com,
        ashevchenko@...ntenna.com, dlebed@...ntenna.com, jiri@...nulli.us,
        ivecera@...hat.com
Subject: Re: [PATCH net-next 1/5] bridge: initialize port flags with
 switchdev defaults

On Fri,  9 Mar 2018 19:03:04 -0800
Igor Mitsyanko <igor.mitsyanko.os@...ntenna.com> wrote:

> Default bridge port flags for switchdev devices can be different from
> what is used in bridging core. Get default value from switchdev itself
> on port initialization.
> 
> Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@...ntenna.com>
> ---

Yes hardware devices may come it with different default values.
But the user experience on Linux needs to be consistent.

Instead, it makes more sense to me for each device driver using switchdev
to program to the values that it sees in the bridge.

Please revise this.