netdev - Re: [PATCH net-next 1/1] net sched actions: return explicit error when tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWUrjvYhXVgdDhDepi8UV-jGRdvmYsK2rMbyFmeL0ZFCQ@mail.gmail.com>
Date:   Mon, 12 Mar 2018 15:55:01 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Amir Vadai <amir@...ai.me>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next 1/1] net sched actions: return explicit error
 when tunnel_key mode is not specified

On Mon, Mar 12, 2018 at 1:20 PM, Roman Mashak <mrv@...atatu.com> wrote:
> If set/unset mode of the tunnel_key action is not provided, ->init() still
> returns 0, and the caller proceeds with bogus 'struct tc_action *' object,
> this results in crash:

...

> Fixes: d0f6dd8a914f ("net/sched: Introduce act_tunnel_key")
> Signed-off-by: Roman Mashak <mrv@...atatu.com>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

This should go to -net rather than -net-next.

Thanks.