netdev - Re: [PATCH net-next 1/1] net sched actions: return explicit error when tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180315.144445.1980513652595896732.davem@davemloft.net>
Date:   Thu, 15 Mar 2018 14:44:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mrv@...atatu.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, amir@...ai.me,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next 1/1] net sched actions: return explicit error
 when tunnel_key mode is not specified

From: Roman Mashak <mrv@...atatu.com>
Date: Mon, 12 Mar 2018 16:20:58 -0400

> If set/unset mode of the tunnel_key action is not provided, ->init() still
> returns 0, and the caller proceeds with bogus 'struct tc_action *' object,
> this results in crash:
> 
> % tc actions add action tunnel_key src_ip 1.1.1.1 dst_ip 2.2.2.1 id 7 index 1
 ...
> Fixes: d0f6dd8a914f ("net/sched: Introduce act_tunnel_key")
> Signed-off-by: Roman Mashak <mrv@...atatu.com>

Applied to net and queued up for -stable.