netdev - Re: [PATCH net] net: fec: Fix unbalanced PM runtime calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1ba3f3e-adef-c7f0-d9b2-47bbdade91f5@gmail.com>
Date:   Sun, 18 Mar 2018 14:42:22 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, andrew@...n.ch, l.stach@...gutronix.de,
        fugang.duan@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: fec: Fix unbalanced PM runtime calls



On 03/18/2018 01:35 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Sun, 18 Mar 2018 12:49:51 -0700
> 
>> When unbinding/removing the driver, we will run into the following warnings:
>>
>> [  259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator
>> [  259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable!
>> [  259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
>> [  259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1
>> [  259.696239] libphy: fec_enet_mii_bus: probed
>>
>> Avoid these warnings by balancing the runtime PM calls during fec_drv_remove().
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Applied, thank you.
> 
> Queue this up for -stable?

I would be inclined to say yes, it was not exactly easy to track down a
set of commits, since this was changed quite a bit.
-- 
Florian