netdev - Re: [PATCH net-next 2/5] cxgb4: Add support to initialise/read SRQ entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180318233705.2072e6b4@epycfail>
Date:   Sun, 18 Mar 2018 23:37:05 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Raju Rangoju <rajur@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com,
        swise@...ngridcomputing.com, bharat@...lsio.com,
        Ganesh Goudar <ganeshgr@...lsio.com>
Subject: Re: [PATCH net-next 2/5] cxgb4: Add support to initialise/read SRQ
 entries

On Sat, 17 Mar 2018 12:52:26 +0530
Raju Rangoju <rajur@...lsio.com> wrote:

> +struct srq_data *t4_init_srq(int srq_size)
> +{
> +	struct srq_data *s;
> +
> +	s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN);
> +	if (!s)
> +		s = vzalloc(sizeof(*s));
> +	if (!s)
> +		return NULL;

I guess you could use kvzalloc() here.

> [...]
>
> +++ b/drivers/net/ethernet/chelsio/cxgb4/srq.h
>
> [...]
>
> +enum {
> +	SRQ_WAIT_TO = (HZ * 5),
> +};

Why not #define? Am I missing something?

-- 
Stefano