netdev - Re: [PATCH net-next 0/4] net: dsa: Plug in PHYLINK support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88771bb1-242f-871c-bd5c-202378132015@gmail.com>
Date:   Mon, 19 Mar 2018 10:45:09 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, privat@...l-hjelmeland.no,
        vivien.didelot@...oirfairelinux.com, davem@...emloft.net,
        rmk+kernel@...linux.org.uk, sean.wang@...iatek.com,
        Woojung.Huh@...rochip.com, john@...ozen.org, cphealy@...il.com
Subject: Re: [PATCH net-next 0/4] net: dsa: Plug in PHYLINK support

On 03/19/2018 06:44 AM, Andrew Lunn wrote:
>> I think I will proceed differently for v2:
>>
>> - introduce DSA phylink_mac_ops in dsa_switch_ops, such that drivers can
>> define those as preliminary commits, those won't be used by
>> net/dsa/slave.c just yet though
>>
>> - have all relevant drivers implement phylink_mac_ops such that the
>> pluming is there and functional
>>
>> - switch net/dsa/slave.c to using PHYLINK
>>
>> That way, we should avoid any breakage in between and have an "atomic"
>> switch between PHYLIB and PHYLINK.
> 
> Hi Florian
> 
> That sounds good. Maybe we can also convert ZII devel B to using SFP
> at the same time?

That should be done, yes.

> 
> I can take a look at implementing the Marvell phylink_mac_ops.

If you could do that, I would be grateful, without the datasheet things
will take time to be reverse engineered for me. AFAIR, Russell had sent
us patches separately that he used.

The way the patch series is structured right now, only the user-facing
ports will need to have phylink_mac_ops, which should help reduce the
amount of testing.

Thanks!
-- 
Florian