netdev - Re: [PATCH V3 net-next 01/14] tcp: Add clean acked data hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180323.132958.1398721012186355078.davem@davemloft.net>
Date:   Fri, 23 Mar 2018 13:29:58 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     netdev@...r.kernel.org, davejwatson@...com, borisp@...lanox.com,
        ilyal@...lanox.com, aviadye@...lanox.com
Subject: Re: [PATCH V3 net-next 01/14] tcp: Add clean acked data hook

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Thu, 22 Mar 2018 15:33:38 -0700

> +#if IS_ENABLED(CONFIG_TLS_DEVICE)
> +DEFINE_STATIC_KEY_FALSE(clean_acked_data_enabled);
> +EXPORT_SYMBOL_GPL(clean_acked_data_enabled);
> +#endif

Please mark this symbol static (otherwise it's name pollutes the global
name space, "clean_acked" what?  for what subsystem? etc.)

And add two helper functions, icsk_clean_acked_enable() and
icsk_clean_acked_disable() which adjust the static key as
needed.

For the enable helper, you can pass in an icsk and the function
pointer, so that the helper can do the assignment and the
connection between the static key and registering on an icsk
is clear.