netdev - Re: [PATCH V3 net-next 06/14] net/tls: Add generic NIC offload infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180323.133108.559607339395182037.davem@davemloft.net>
Date:   Fri, 23 Mar 2018 13:31:08 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     netdev@...r.kernel.org, davejwatson@...com, borisp@...lanox.com,
        ilyal@...lanox.com, aviadye@...lanox.com
Subject: Re: [PATCH V3 net-next 06/14] net/tls: Add generic NIC offload
 infrastructure

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Thu, 22 Mar 2018 15:33:43 -0700

> diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
> new file mode 100644
> index 000000000000..34555ac0b959
> --- /dev/null
> +++ b/net/tls/tls_device.c
 ...
> +static inline void tls_append_frag(struct tls_record_info *record,
> +				   struct page_frag *pfrag,
> +				   int size)

Do not use the inline keyword in foo.c files, please let the compiler
make that determination.

Please audit this entire submission for this problem.

Thank you.