netdev - Re: [PATCH net-next 1/1] net sched actions: merge event notification routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180326.101924.2024941615739873928.davem@davemloft.net>
Date:   Mon, 26 Mar 2018 10:19:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mrv@...atatu.com
Cc:     netdev@...r.kernel.org, kernel@...atatu.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next 1/1] net sched actions: merge event
 notification routines

From: Roman Mashak <mrv@...atatu.com>
Date: Thu, 22 Mar 2018 18:00:25 -0400

> Collapse tca_get_notify(), tca_add_notify() and tca_del_notify() in a
> single function since they repeat the same code pattern.
> 
> Signed-off-by: Roman Mashak <mrv@...atatu.com>

This really doesn't improve the situation.

Instead of a couple clearly coded helpers, you now have one which is
bombed with conditionals that change it's behavior based upon the
event that gets passed in.

This is much less intuitive than how the code is now.

I'm not applying this, sorry.