netdev - Re: [PATCH net-next] XDP router for veth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Mar 2018 10:21:10 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mislam4@...t.edu
Cc:     ebiederm@...ssion.com, xemul@...nvz.org, netdev@...r.kernel.org,
        shemminger@...l.org, edumazet@...gle.com, dsahern@...il.com,
        roopa@...ulusnetworks.com, tom@...bertland.com,
        alexei.starovoitov@...il.com, f.fainelli@...il.com,
        brouer@...hat.com
Subject: Re: [PATCH net-next] XDP router for veth

From: "Md. Islam" <mislam4@...t.edu>
Date: Fri, 23 Mar 2018 02:43:16 -0400

> +#ifdef CONFIG_XDP_ROUTER
> +        //if IP forwarding is enabled on the receiver, create xdp_buff
> +        //from skb and call xdp_router_forward()

Never use C++ comments, only use C style.

> +        if(is_forwarding_enabled(rcv)){

There must be a space between 'if' and the openning parenthesis.  You need
to also have a space before the openning curly braces.

In fact this entire patch is full of coding style issues, please run your
changes through checkpatch.pl before resubmitting.