netdev - Re: [PATCH net-next] XDP router for veth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFgPn1CZ4E=FaHvywCoTpWGo9y5bzF7nmvwUmUQDnzE+wx=yOg@mail.gmail.com>
Date:   Mon, 26 Mar 2018 21:01:28 -0400
From:   "Md. Islam" <mislam4@...t.edu>
To:     David Miller <davem@...emloft.net>
Cc:     ebiederm@...ssion.com, Pavel Emelyanov <xemul@...nvz.org>,
        netdev@...r.kernel.org, shemminger@...l.org,
        Eric Dumazet <edumazet@...gle.com>,
        David Ahern <dsahern@...il.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        Tom Herbert <tom@...bertland.com>,
        alexei.starovoitov@...il.com,
        Florian Fainelli <f.fainelli@...il.com>, brouer@...hat.com,
        bjorn.topel@...il.com, magnus.karlsson@...el.com,
        u9012063@...il.com
Subject: Re: [PATCH net-next] XDP router for veth

On Mon, Mar 26, 2018 at 10:21 AM, David Miller <davem@...emloft.net> wrote:
> From: "Md. Islam" <mislam4@...t.edu>
> Date: Fri, 23 Mar 2018 02:43:16 -0400
>
>> +#ifdef CONFIG_XDP_ROUTER
>> +        //if IP forwarding is enabled on the receiver, create xdp_buff
>> +        //from skb and call xdp_router_forward()
>
> Never use C++ comments, only use C style.
>
>> +        if(is_forwarding_enabled(rcv)){
>
> There must be a space between 'if' and the openning parenthesis.  You need
> to also have a space before the openning curly braces.
>
> In fact this entire patch is full of coding style issues, please run your
> changes through checkpatch.pl before resubmitting.


Thanks David for the suggestions! I fixed all the formating errors. I
also modified the forwarding logic. Now the iperf throughput improved
from
53.8Gb/s to around 60Gb/s and the median RTT improved from .055 ms to
.35 ms. The patch is attached.

View attachment "xdp-fastpath.patch" of type "text/x-patch" (8409 bytes)