netdev - RE: [PATCH net-next] tipc: fix error handling in tipc_udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Mar 2018 14:44:57 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Ying Xue <ying.xue@...driver.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH net-next] tipc: fix error handling in tipc_udp_enable()

Acked-by: Jon Maloy <jon.maloy@...csson.com>
Thank you, Wei.

> -----Original Message-----
> From: Wei Yongjun [mailto:weiyongjun1@...wei.com]
> Sent: Monday, March 26, 2018 10:33
> To: Jon Maloy <jon.maloy@...csson.com>; Ying Xue
> <ying.xue@...driver.com>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; netdev@...r.kernel.org;
> tipc-discussion@...ts.sourceforge.net; kernel-janitors@...r.kernel.org
> Subject: [PATCH net-next] tipc: fix error handling in tipc_udp_enable()
> 
> Release alloced resource before return from the error handling case in
> tipc_udp_enable(), otherwise will cause memory leak.
> 
> Fixes: 52dfae5c85a4 ("tipc: obtain node identity from interface by default")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  net/tipc/udp_media.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index
> 2c13b18..e7d91f5 100644
> --- a/net/tipc/udp_media.c
> +++ b/net/tipc/udp_media.c
> @@ -687,7 +687,8 @@ static int tipc_udp_enable(struct net *net, struct
> tipc_bearer *b,
>  	}
>  	if (!tipc_own_id(net)) {
>  		pr_warn("Failed to set node id, please configure
> manually\n");
> -		return -EINVAL;
> +		err = -EINVAL;
> +		goto err;
>  	}
> 
>  	b->bcast_addr.media_id = TIPC_MEDIA_TYPE_UDP;