netdev - RE: [PATCH net-next] tipc: tipc_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN6PR15MB15538D318F2D45E3D626FF5D9AAD0@BN6PR15MB1553.namprd15.prod.outlook.com>
Date:   Mon, 26 Mar 2018 14:45:46 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Ying Xue <ying.xue@...driver.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH net-next] tipc: tipc_node_create() can be static

Acked-by: Jon Maloy <jon.maloy@...csson.com>
Thanks
///jon

> -----Original Message-----
> From: Wei Yongjun [mailto:weiyongjun1@...wei.com]
> Sent: Monday, March 26, 2018 10:33
> To: Jon Maloy <jon.maloy@...csson.com>; Ying Xue
> <ying.xue@...driver.com>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; netdev@...r.kernel.org;
> tipc-discussion@...ts.sourceforge.net; kernel-janitors@...r.kernel.org
> Subject: [PATCH net-next] tipc: tipc_node_create() can be static
> 
> Fixes the following sparse warning:
> 
> net/tipc/node.c:336:18: warning:
>  symbol 'tipc_node_create' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  net/tipc/node.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/tipc/node.c b/net/tipc/node.c index 4a95c8c..4fb4327 100644
> --- a/net/tipc/node.c
> +++ b/net/tipc/node.c
> @@ -333,8 +333,8 @@ static void tipc_node_write_unlock(struct tipc_node
> *n)
>  	}
>  }
> 
> -struct tipc_node *tipc_node_create(struct net *net, u32 addr,
> -				   u8 *peer_id, u16 capabilities)
> +static struct tipc_node *tipc_node_create(struct net *net, u32 addr,
> +					  u8 *peer_id, u16 capabilities)
>  {
>  	struct tipc_net *tn = net_generic(net, tipc_net_id);
>  	struct tipc_node *n, *temp_node;