netdev - Re: [bpf-next PATCH] net: br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <306fcd44-3cec-c78e-ede6-87cd6f56e01f@gmail.com>
Date:   Tue, 27 Mar 2018 08:57:00 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     stephen@...workplumber.org, 3chas3@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [bpf-next PATCH] net: br_vlan build error

On 03/27/2018 08:38 AM, John Fastabend wrote:
> Fix build error in br_if.c
> 
> net/bridge/br_if.c: In function ‘br_mtu’:
> net/bridge/br_if.c:458:8: error: ‘const struct net_bridge’ has no member named ‘vlan_enabled’
>   if (br->vlan_enabled)
>         ^
> net/bridge/br_if.c:462:1: warning: control reaches end of non-void function [-Wreturn-type]
>  }
>  ^
> Fixes: 419d14af9e07f ("bridge: Allow max MTU when multiple VLANs present")
> Signed-off-by: John Fastabend <john.fastabend@...il.com>
> ---

This is against net-next sorry for any confusion. Let me know
if you need me to respin.

@Chas, also I only build tested this to get my kernels building
again. You should probably verify I implemented what you expect
in the case without vlan filtering. It seems correct to me but
I'm not the expert here.

Thanks,
John