netdev - Re: [bpf-next PATCH] net: br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b022da8d-d621-351b-69d3-a3817344b939@gmail.com>
Date:   Tue, 27 Mar 2018 08:58:47 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        stephen@...workplumber.org, 3chas3@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [bpf-next PATCH] net: br_vlan build error

On 03/27/2018 08:49 AM, Nikolay Aleksandrov wrote:
> On 27/03/18 18:38, John Fastabend wrote:
>> Fix build error in br_if.c
>>
>> net/bridge/br_if.c: In function ‘br_mtu’:
>> net/bridge/br_if.c:458:8: error: ‘const struct net_bridge’ has no member named ‘vlan_enabled’
>>   if (br->vlan_enabled)
>>         ^
>> net/bridge/br_if.c:462:1: warning: control reaches end of non-void function [-Wreturn-type]
>>  }
>>  ^
>> Fixes: 419d14af9e07f ("bridge: Allow max MTU when multiple VLANs present")
>> Signed-off-by: John Fastabend <john.fastabend@...il.com>
>> ---
>>  net/bridge/br_if.c |   27 +++++++++++++++++----------
>>  1 file changed, 17 insertions(+), 10 deletions(-)
>>
> 
> I'm not sure what the rules about merging are, but just in case I
> already fixed this in net-next couple of days ago.
> 
> commit 82792a070b16
> Author: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Date:   Fri Mar 23 18:27:06 2018 +0200
> 
>     net: bridge: fix direct access to bridge vlan_enabled and use helper
> 
> https://patchwork.ozlabs.org/patch/890043/
> 
> 
> Cheers,
>  Nik
> 

Ah dang sorry about the noise then drop my patch.