netdev - Re: [PATCH v14 net-next 09/12] crypto: chtls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52183607-b227-dc53-4a94-9408c5a4ecaf@chelsio.com>
Date:   Fri, 30 Mar 2018 00:54:09 +0530
From:   Atul Gupta <atul.gupta@...lsio.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     davem@...emloft.net, herbert@...dor.apana.org.au,
        davejwatson@...com, sbrivio@...hat.com,
        linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
        werner@...lsio.com, leedom@...lsio.com,
        swise@...ngridcomputing.com, indranil@...lsio.com,
        ganeshgr@...lsio.com
Subject: Re: [PATCH v14 net-next 09/12] crypto: chtls - Inline TLS record Tx



On 3/29/2018 9:56 PM, Sabrina Dubroca wrote:
> 2018-03-29, 21:27:51 +0530, Atul Gupta wrote:
>> TLS handler for record transmit.
>> Create Inline TLS work request and post to FW.
>> Create Inline TLS record CPLs for hardware
>>
>> Signed-off-by: Atul Gupta <atul.gupta@...lsio.com>
>> Signed-off-by: Michael Werner <werner@...lsio.com>
>> ---
> ...
>> +int chtls_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
>> +{
>> +	struct chtls_sock *csk = rcu_dereference_sk_user_data(sk);
>> +	struct chtls_dev *cdev = csk->cdev;
>> +	struct tcp_sock *tp = tcp_sk(sk);
>> +	struct sk_buff *skb;
>> +	int mss, flags, err;
>> +	int recordsz = 0;
>> +	int copied = 0;
>> +	int hdrlen = 0;
>> +	long timeo;
>> +
>> +	lock_sock(sk);
>> +	flags = msg->msg_flags;
>> +	timeo = sock_sndtimeo(sk, flags & MSG_DONTWAIT);
>> +
>> +	if (!sk_in_state(sk, TCPF_ESTABLISHED | TCPF_CLOSE_WAIT)) {
>> +		err = sk_stream_wait_connect(sk, &timeo);
>> +		if (err)
>> +			goto out_err;
>> +	}
>> +
>> +	if (sk->sk_prot->sendmsg != chtls_sendmsg) {
> Can that actually happen? If so, how? AFAICT, this function is only
> called when sk->sk_prot has been set to be chtls_cpl_prot.
this is relevant for the tunneling of the active-open path and can be removed for now
>
>> +		release_sock(sk);
>> +		if (sk->sk_prot->sendmsg)
>> +			return sk->sk_prot->sendmsg(sk, msg, size);
>> +		else
>> +			return sk->sk_socket->ops->sendmsg(sk->sk_socket,
>> +							   msg, size);
>> +	}