netdev - Re: [PATCH v14 net-next 08/12] crypto : chtls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Mar 2018 21:11:00 +0530
From:   Ganesh Goudar <ganeshgr@...lsio.com>
To:     sd@...asysnail.net
Cc:     Sabrina Dubroca <sd@...asysnail.net>, davem@...emloft.net,
        herbert@...dor.apana.org.au, davejwatson@...com,
        sbrivio@...hat.com, linux-crypto@...r.kernel.org,
        netdev@...r.kernel.org, werner@...lsio.com, leedom@...lsio.com,
        swise@...ngridcomputing.com, indranil@...lsio.com, atul@...lsio.com
Subject: Re: [PATCH v14 net-next 08/12] crypto : chtls - CPL handler
 definition

On Friday, March 03/30/18, 2018 at 00:38:06 +0530, Atul Gupta wrote:
> 
> 
> On 3/29/2018 9:56 PM, Sabrina Dubroca wrote:
> > 2018-03-29, 21:27:50 +0530, Atul Gupta wrote:
> > ...
> >> +static void chtls_pass_accept_request(struct sock *sk,
> >> +				      struct sk_buff *skb)
> >> +{
> > ...
> >> +	if (chtls_get_module(newsk))
> >> +		goto reject;
> >> +	inet_csk_reqsk_queue_added(sk);
> >> +	reply_skb->sk = newsk;
> >> +	chtls_install_cpl_ops(newsk);
> > Function defined in patch 11, declared in patch 6, and used in patch
> > 8.  Are you actually listening to the comments we've been sending?
> Patch series is broken to make it bisectable, it ensures that existing modules net, cxgb4, chcr compiles fine, since chtls is new module the sequence of patches builds clean by virtue of having Makefile change in the last patch. We have followed a similar approach in the past for new submission of chcr, cxgbit drivers.
> >
>
I hope you are fine with this, we will take care of your other comment in V15
and submit.

Thanks