netdev - Re: [PATCH net-next] net: Call add/kill vid ndo on vlan filter feature toggling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180330.095912.583403211441224950.davem@davemloft.net>
Date:   Fri, 30 Mar 2018 09:59:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     galp@...lanox.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com
Subject: Re: [PATCH net-next] net: Call add/kill vid ndo on vlan filter
 feature toggling

From: Gal Pressman <galp@...lanox.com>
Date: Wed, 28 Mar 2018 17:46:54 +0300

> NETIF_F_HW_VLAN_[CS]TAG_FILTER features require more than just a bit
> flip in dev->features in order to keep the driver in a consistent state.
> These features notify the driver of each added/removed vlan, but toggling
> of vlan-filter does not notify the driver accordingly for each of the
> existing vlans.
> 
> This patch implements a similar solution to NETIF_F_RX_UDP_TUNNEL_PORT
> behavior (which notifies the driver about UDP ports in the same manner
> that vids are reported).
> 
> Each toggling of the features propagates to the 8021q module, which
> iterates over the vlans and call add/kill ndo accordingly.
> 
> Signed-off-by: Gal Pressman <galp@...lanox.com>
> Reviewed-by: Tariq Toukan <tariqt@...lanox.com>

Looks good, applied, thank you.