netdev - Re: [PATCH net-next v2 0/3] net: Broadcom drivers coalescing fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180330.100450.1179936472848227878.davem@davemloft.net>
Date:   Fri, 30 Mar 2018 10:04:50 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, jaedon.shin@...il.com, pgynther@...gle.com,
        opendmb@...il.com, michael.chan@...adcom.com, gospo@...adcom.com,
        talgi@...lanox.com, saeedm@...lanox.com
Subject: Re: [PATCH net-next v2 0/3] net: Broadcom drivers coalescing fixes

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 28 Mar 2018 15:15:35 -0700

> Following Tal's review of the adaptive RX/TX coalescing feature added to the
> SYSTEMPORT and GENET driver a number of things showed up:
> 
> - adaptive TX coalescing is not actually a good idea with the current way
>   the estimator will program the ring, this results in a higher CPU load, NAPI
>   on TX already does a reasonably good job at maintaining the interrupt count low
> 
> - both SYSTEMPORT and GENET would suffer from the same issues while configuring
>   coalescing parameters where the values would just not be applied correctly
>   based on user settings, so we fix that too
> 
> Tal, thanks again for your feedback, I would appreciate if you could review that
> the new behavior appears to be implemented correctly.
 ...
> Changes in v2:
> 
> - added Tal's reviewed-by to the first patch
> - split DIM initialization from coalescing parameters initialization
> - avoid duplicating the same code in bcmgenet_set_coalesce() when configuring RX rings
> - fixed the condition where default DIM parameters would be applied when
>   adaptive RX coalescing would be enabled, do this only if it was disabled before

Series applied, thanks Florian.