netdev - Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation to net DIM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180331.231929.1875689505974197531.davem@davemloft.net>
Date:   Sat, 31 Mar 2018 23:19:29 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     talgi@...lanox.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com,
        andrew.gospodarek@...adcom.com, saeedm@...lanox.com
Subject: Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt
 moderation to net DIM

From: David Miller <davem@...emloft.net>
Date: Sat, 31 Mar 2018 22:02:55 -0400 (EDT)

> From: Tal Gilboa <talgi@...lanox.com>
> Date: Fri, 30 Mar 2018 09:37:29 +0300
> 
>> Net DIM is a library designed for dynamic interrupt moderation. It was
>> implemented and optimized with receive side interrupts in mind, since these
>> are usually the CPU expensive ones. This patch-set introduces adaptive transmit
>> interrupt moderation to net DIM, complete with a usage in the mlx5e driver.
>> Using adaptive TX behavior would reduce interrupt rate for multiple scenarios.
>> Furthermore, it is essential for increasing bandwidth on cases where payload
>> aggregation is required.
> 
> Series applied.

This breaks the build:

drivers/net/ethernet/broadcom/bcmsysport.c: In function ‘bcm_sysport_set_coalesce’:
drivers/net/ethernet/broadcom/bcmsysport.c:657:11: error: implicit declaration of function ‘net_dim_get_def_profile’; did you mean ‘net_dim_exit_parking’? [-Werror=implicit-function-declaration]
   moder = net_dim_get_def_profile(priv->dim.dim.mode);
           ^~~~~~~~~~~~~~~~~~~~~~~