netdev - Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation to net DIM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab7dafdf-e21d-183a-d032-fca89678574b@mellanox.com>
Date:   Sun, 1 Apr 2018 09:49:21 +0300
From:   Tal Gilboa <talgi@...lanox.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com,
        andrew.gospodarek@...adcom.com, saeedm@...lanox.com
Subject: Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation
 to net DIM

On 4/1/2018 6:19 AM, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Sat, 31 Mar 2018 22:02:55 -0400 (EDT)
> 
>> From: Tal Gilboa <talgi@...lanox.com>
>> Date: Fri, 30 Mar 2018 09:37:29 +0300
>>
>>> Net DIM is a library designed for dynamic interrupt moderation. It was
>>> implemented and optimized with receive side interrupts in mind, since these
>>> are usually the CPU expensive ones. This patch-set introduces adaptive transmit
>>> interrupt moderation to net DIM, complete with a usage in the mlx5e driver.
>>> Using adaptive TX behavior would reduce interrupt rate for multiple scenarios.
>>> Furthermore, it is essential for increasing bandwidth on cases where payload
>>> aggregation is required.
>>
>> Series applied.
> 
> This breaks the build:
> 
> drivers/net/ethernet/broadcom/bcmsysport.c: In function ‘bcm_sysport_set_coalesce’:
> drivers/net/ethernet/broadcom/bcmsysport.c:657:11: error: implicit declaration of function ‘net_dim_get_def_profile’; did you mean ‘net_dim_exit_parking’? [-Werror=implicit-function-declaration]
>     moder = net_dim_get_def_profile(priv->dim.dim.mode);
>             ^~~~~~~~~~~~~~~~~~~~~~~
> 
Rebase issues, sorry.
Sent a fixup patch.