netdev - Re: [net-next V8 PATCH 01/16] mlx5: basic XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180331.233115.994657800927602157.davem@davemloft.net>
Date:   Sat, 31 Mar 2018 23:31:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     netdev@...r.kernel.org, bjorn.topel@...el.com,
        magnus.karlsson@...el.com, eugenia@...lanox.com,
        jasowang@...hat.com, john.fastabend@...il.com, eranbe@...lanox.com,
        saeedm@...lanox.com, galp@...lanox.com, borkmann@...earbox.net,
        alexei.starovoitov@...il.com, tariqt@...lanox.com
Subject: Re: [net-next V8 PATCH 01/16] mlx5: basic XDP_REDIRECT forward
 support

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Sat, 31 Mar 2018 14:05:52 +0200

> +static inline void mlx5e_page_dma_unmap(struct mlx5e_rq *rq,
> +					struct mlx5e_dma_info *dma_info)

Please do not use the inline keyword in foo.c files, let the compiler
decide.

I know that this is done in other areas of this file, that just means
that I didn't catch it when those changes went it, rather than meaning
that the rule can be broken because it has been already.

Thank you.