netdev - Re: [net-next V8 PATCH 13/16] xdp: allow page_pool as an allocator type in xdp_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Mar 2018 23:32:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     netdev@...r.kernel.org, bjorn.topel@...el.com,
        magnus.karlsson@...el.com, eugenia@...lanox.com,
        jasowang@...hat.com, john.fastabend@...il.com, eranbe@...lanox.com,
        saeedm@...lanox.com, galp@...lanox.com, borkmann@...earbox.net,
        alexei.starovoitov@...il.com, tariqt@...lanox.com
Subject: Re: [net-next V8 PATCH 13/16] xdp: allow page_pool as an allocator
 type in xdp_return_frame

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Sat, 31 Mar 2018 14:06:52 +0200

> diff --git a/net/core/xdp.c b/net/core/xdp.c
> index 8b2cb79b5de0..d8115903e454 100644
> --- a/net/core/xdp.c
> +++ b/net/core/xdp.c
 ...
> +static inline bool __is_supported_mem_type(enum xdp_mem_type type)

Again, please don't use inline in foo.c files.

Thank you.