netdev - Re: [net-next V8 PATCH 01/16] mlx5: basic XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f560395f-af4e-cf81-5085-c763e58ca429@mellanox.com>
Date:   Sun, 1 Apr 2018 11:46:50 +0300
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org,
        BjörnTöpel <bjorn.topel@...el.com>,
        magnus.karlsson@...el.com
Cc:     eugenia@...lanox.com, Jason Wang <jasowang@...hat.com>,
        John Fastabend <john.fastabend@...il.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>, galp@...lanox.com,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net-next V8 PATCH 01/16] mlx5: basic XDP_REDIRECT forward
 support



On 31/03/2018 3:05 PM, Jesper Dangaard Brouer wrote:

..

> @@ -844,6 +851,15 @@ static inline int mlx5e_xdp_handle(struct mlx5e_rq *rq,
>   		if (unlikely(!mlx5e_xmit_xdp_frame(rq, di, &xdp)))
>   			trace_xdp_exception(rq->netdev, prog, act);
>   		return true;
> +	case XDP_REDIRECT:
> +		/* When XDP enabled then page-refcnt==1 here */
> +		err = xdp_do_redirect(rq->netdev, &xdp, prog);
> +		if (!err) {
> +			rq->wqe.xdp_xmit = true; /* XDP xmit owns page */

boolean xdp_xmit does not exist anymore, it was removed recently by:
121e89275471 net/mlx5e: Refactor RQ XDP_TX indication

please replace with:
			__set_bit(MLX5E_RQ_FLAG_XDP_XMIT, rq->flags);

> +			rq->xdpsq.db.redirect_flush = true;
> +			mlx5e_page_dma_unmap(rq, di);
> +		}
> +		return true;
>   	default:
>   		bpf_warn_invalid_xdp_action(act);
>   	case XDP_ABORTED: