netdev - Re: [PATCH] VSOCK: make af_vsock.ko removable again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180417.094512.321362741144442657.davem@davemloft.net>
Date:   Tue, 17 Apr 2018 09:45:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     stefanha@...hat.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com,
        jhansen@...are.com
Subject: Re: [PATCH] VSOCK: make af_vsock.ko removable again

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Tue, 17 Apr 2018 14:25:58 +0800

> Commit c1eef220c1760762753b602c382127bfccee226d ("vsock: always call
> vsock_init_tables()") introduced a module_init() function without a
> corresponding module_exit() function.
> 
> Modules with an init function can only be removed if they also have an
> exit function.  Therefore the vsock module was considered "permanent"
> and could not be removed.
> 
> This patch adds an empty module_exit() function so that "rmmod vsock"
> works.  No explicit cleanup is required because:
> 
> 1. Transports call vsock_core_exit() upon exit and cannot be removed
>    while sockets are still alive.
> 2. vsock_diag.ko does not perform any action that requires cleanup by
>    vsock.ko.
> 
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Cc: Jorgen Hansen <jhansen@...are.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>

Applied, but please provide a proper Fixes: tag next time.  I added it
for you this time.