netdev - Re: [PATCH] VSOCK: make af_vsock.ko removable again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180418041451.GB25649@stefanha-x1.localdomain>
Date:   Wed, 18 Apr 2018 12:14:51 +0800
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com,
        jhansen@...are.com
Subject: Re: [PATCH] VSOCK: make af_vsock.ko removable again

On Tue, Apr 17, 2018 at 09:45:12AM -0400, David Miller wrote:
> From: Stefan Hajnoczi <stefanha@...hat.com>
> Date: Tue, 17 Apr 2018 14:25:58 +0800
> 
> > Commit c1eef220c1760762753b602c382127bfccee226d ("vsock: always call
> > vsock_init_tables()") introduced a module_init() function without a
> > corresponding module_exit() function.
> > 
> > Modules with an init function can only be removed if they also have an
> > exit function.  Therefore the vsock module was considered "permanent"
> > and could not be removed.
> > 
> > This patch adds an empty module_exit() function so that "rmmod vsock"
> > works.  No explicit cleanup is required because:
> > 
> > 1. Transports call vsock_core_exit() upon exit and cannot be removed
> >    while sockets are still alive.
> > 2. vsock_diag.ko does not perform any action that requires cleanup by
> >    vsock.ko.
> > 
> > Reported-by: Xiumei Mu <xmu@...hat.com>
> > Cc: Cong Wang <xiyou.wangcong@...il.com>
> > Cc: Jorgen Hansen <jhansen@...are.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> 
> Applied, but please provide a proper Fixes: tag next time.  I added it
> for you this time.

Will do.  Thanks!

Stefan

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)