netdev - Re: [PATCH] net/tls: remove redundant second null check on sgout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180424.160225.1434022836243113911.davem@davemloft.net>
Date:   Tue, 24 Apr 2018 16:02:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     ilyal@...lanox.com, aviadye@...lanox.com, davejwatson@...com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/tls: remove redundant second null check on sgout

From: Colin King <colin.king@...onical.com>
Date: Tue, 24 Apr 2018 13:36:58 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> A duplicated null check on sgout is redundant as it is known to be
> already true because of the identical earlier check. Remove it.
> Detected by cppcheck:
> 
> net/tls/tls_sw.c:696: (warning) Identical inner 'if' condition is always
> true.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to net-next, thank you.